Skip to content

feat: add boolean datatype support in array/dtypes #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 13, 2024
Merged

feat: add boolean datatype support in array/dtypes #2307

merged 8 commits into from
Jun 13, 2024

Conversation

Jaysukh-409
Copy link
Member

Resolves: Subtask of #2304

Description

What is the purpose of this pull request?

This pull request:

  • This PR will add boolean datatype support in array/dtypes.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte added the Enhancement Issue or pull request for enhancing existing functionality. label Jun 6, 2024
kgryte
kgryte approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like we need to get a couple of the other PRs merged in for this package's tests to pass. I'll review those so we can make CI happy.

@Jaysukh-409 Jaysukh-409 deleted the array/dtypes branch June 11, 2024 10:03
@kgryte kgryte restored the array/dtypes branch June 11, 2024 10:03
@kgryte
Copy link
Member

kgryte commented Jun 11, 2024

@Jaysukh-409 Did you mean to delete this branch?

@kgryte kgryte reopened this Jun 11, 2024
@kgryte
Copy link
Member

kgryte commented Jun 12, 2024

@Jaysukh-409 Looks like we need to update next-dtype before we can get CI to pass for this PR.

@kgryte
Copy link
Member

kgryte commented Jun 12, 2024

@Jaysukh-409 Would you mind updating promotion-rules next?

@kgryte
Copy link
Member

kgryte commented Jun 13, 2024

CI is now fully green. Will go ahead and merge this PR. Thanks, @Jaysukh-409!

@kgryte kgryte merged commit c417923 into stdlib-js:develop Jun 13, 2024
8 checks passed
@kgryte kgryte deleted the array/dtypes branch June 13, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Enhancement Issue or pull request for enhancing existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaysukh-409 @kgryte